Skip to content

Drop requiring type parameter in webhook model for RBS #477

Merged
Yang-33 merged 2 commits intoline:masterfrom
Yang-33:steep-initialize-webhook
Apr 8, 2025
Merged

Drop requiring type parameter in webhook model for RBS #477
Yang-33 merged 2 commits intoline:masterfrom
Yang-33:steep-initialize-webhook

Conversation

@Yang-33
Copy link
Copy Markdown
Contributor

@Yang-33 Yang-33 commented Apr 8, 2025

In implementation, it donen't require type as a keyword parameter.

ref:

# @param source [Source,nil]
# @param timestamp [Integer] Time of the event in milliseconds.
# @param mode [String] ('active'|'standby')
# @param webhook_event_id [String] Webhook Event ID. An ID that uniquely identifies a webhook event. This is a string in ULID format.
# @param delivery_context [DeliveryContext]
# @param reply_token [String,nil] Reply token used to send reply message to this event. This property won't be included if linking the account has failed.
# @param link [LinkContent]
def initialize(
source: nil,
timestamp:,
mode:,
webhook_event_id:,
delivery_context:,
reply_token: nil,
link:,
**dynamic_attributes

@Yang-33 Yang-33 self-assigned this Apr 8, 2025
@Yang-33 Yang-33 requested a review from a team April 8, 2025 06:59
Copy link
Copy Markdown
Contributor

@mokuzon mokuzon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, it slipped my mind.

@Yang-33 Yang-33 added this pull request to the merge queue Apr 8, 2025
@Yang-33
Copy link
Copy Markdown
Contributor Author

Yang-33 commented Apr 8, 2025

never mind~

Merged via the queue into line:master with commit c901699 Apr 8, 2025
6 checks passed
@Yang-33 Yang-33 deleted the steep-initialize-webhook branch April 8, 2025 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants